Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix flaky tests. #3717

Merged
merged 1 commit into from
Oct 22, 2024
Merged

Fix flaky tests. #3717

merged 1 commit into from
Oct 22, 2024
+5 −5

Conversation

bmarty
Copy link
Member

@bmarty bmarty commented Oct 21, 2024

Content

Ensure test run locally and on the CI in a deterministic way.

Motivation and context

Fix flaky test recently introduced.

Screenshots / GIFs

Tests

  • NA

Tested devices

  • NA

Checklist

  • Changes have been tested on an Android device or Android emulator with API 23
  • UI change has been tested on both light and dark themes
  • Accessibility has been taken into account. See https://github.com/element-hq/element-x-android/blob/develop/CONTRIBUTING.md#accessibility
  • Pull request is based on the develop branch
  • Pull request title will be used in the release note, it clearly define what will change for the user
  • Pull request includes screenshots or videos if containing UI changes
  • Pull request includes a sign off
  • You've made a self review of your PR

@bmarty bmarty requested a review from a team as a code owner October 21, 2024 20:44
@bmarty bmarty requested review from jmartinesp and removed request for a team October 21, 2024 20:44
@bmarty bmarty added the PR-Misc For other changes label Oct 21, 2024
@bmarty bmarty mentioned this pull request Oct 21, 2024
Merged
@github-actions GitHub Actions
Copy link
Contributor

📱 Scan the QR code below to install the build (arm64 only) for this PR.
QR code
If you can't scan the QR code you can install the build via this link: https://i.diawi.com/pC96D6

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Oct 21, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@codecov Codecov
Copy link

codecov bot commented Oct 21, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 83.02%. Comparing base (804506b) to head (9eabc83).
Report is 7 commits behind head on develop.

Additional details and impacted files 
@@           Coverage Diff            @@
##           develop    #3717   +/-   ##
========================================
  Coverage    83.02%   83.02%           
========================================
  Files         1752     1752           
  Lines        43782    43782           
  Branches      5122     5122           
========================================
  Hits         36351    36351           
  Misses        5611     5611           
  Partials      1820     1820

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

jmartinesp
jmartinesp approved these changes Oct 22, 2024
View reviewed changes
Copy link
Member

@jmartinesp jmartinesp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems a better solution than the delay, let's see if it fixes the flaky tests 🤞 .

@bmarty bmarty merged commit 45f4e54 into develop Oct 22, 2024
30 checks passed
@bmarty bmarty deleted the feature/bma/fixFlakyTest branch October 22, 2024 07:44
@bmarty bmarty mentioned this pull request Oct 22, 2024
Merged
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jmartinesp jmartinesp jmartinesp approved these changes

Assignees
No one assigned
Labels
PR-Misc For other changes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bmarty @jmartinesp